Skip to content

Implement experimental module selectors (MyMod::someName) feature #34556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Implement experimental module selectors (MyMod::someName) feature #34556

wants to merge 28 commits into from
+3,008 −490

Conversation

beccadax
Copy link
Contributor

@beccadax beccadax commented Nov 3, 2020 •
edited
Loading

This pull request begins to implement "module selectors", which allow references to declarations to be unambiguously prefixed with a module they can be found through:

class MyClass: ObjectiveC::NSObject {}  // OK, ObjectiveC defines NSObject
class MyClass: Foundation::NSObject {}  // OK, Foundation re-exports NSObject
class MyClass: Swift::NSObject {}       // error, Swift does not re-export or define NSObject
class MyClass: MyModule::NSObject {}    // error, MyModule does not re-export or define NSObject

This PR parses module selectors and partially implements lookup and diagnostics for them. The new functionality is hidden behind an -enable-experimental-module-selector frontend flag. There is one diagnostic regression with that flag enabled, but I've made sure that it keeps working when the diagnostic is disabled.

This work was previously in PR #28834, which was closed during the master-to-main transition. I've updated it to work on modern compilers, including removing some FIXMEs for bad diagnostics that have improved since December 2019.

Makes progress on rdar://problem/19481048.

@beccadax beccadax changed the title Module selectors Implement experimental module selectors (MyMod::someName) feature Nov 3, 2020
@beccadax beccadax force-pushed the mod-squad-2 branch 3 times, most recently from eb8ecdf to b6d41f6 Compare July 21, 2021 20:18
@beccadax beccadax mentioned this pull request Jul 21, 2021
Merged
beccadax
beccadax commented Jul 21, 2021
View reviewed changes
@beccadax beccadax mentioned this pull request Aug 3, 2021
Merged
@beccadax beccadax force-pushed the mod-squad-2 branch 3 times, most recently from 9c9e8e9 to 6edf769 Compare August 6, 2021 19:38
@beccadax beccadax mentioned this pull request May 9, 2025
Merged
@nkcsgexi
Copy link
Contributor

Woohoo! Thank you for reviving this, Becca!

@beccadax beccadax mentioned this pull request May 12, 2025
Merged
@beccadax beccadax marked this pull request as draft May 15, 2025 23:31
@beccadax beccadax mentioned this pull request Jun 2, 2025
Merged
beccadax added 16 commits August 20, 2025 17:05
@beccadax
[NFC] Add skeleton of module selector lookup test
3d52834 
The diagnostics in this test will evolve as we implement pieces of the feature.
@beccadax
[NFC] Improve some lookup-related doc comments
977b8a7
@beccadax
[NFC] Add representations for DeclNameRef/Loc with module selector
3d449c5
@beccadax
[NFC] Audit some DeclName➡️DeclNameRef conversions
e8e3346 
Adds comments explaining why these conversions aren’t lossy.
@beccadax
Handle module selectors in qualified lookup
6608d38
@beccadax
Root unqualified lookups with module selectors at file scope
c2dedb0
@beccadax
Handle module selectors in unqualified lookup
f31ab47
@beccadax
Handle module selectors in UDRE lookups
c754d06
@beccadax
FIXME operators unexpectedly passing
c13cbda
@beccadax
Handle module selectors with local vars right
ca3b6d1
@beccadax
Improve module selector type lookup diagnostics
b7e1b70
@beccadax
Improve module selector expr lookup diagnostics
d9c83ac
@beccadax
Improve module selector constraint solver diagnostics
2e84375
@beccadax
Improve module selector @_dynamicReplacement diagnostics
fb6e7e7
@beccadax
[NFC] Pipe PrintDiagnosticNames through swiftinterface loader
804ee6b
@beccadax
Fix lookup into Builtin with module selector
1c737e0 
Lookups like Builtin::Int64 were failing because BuiltinUnit rejected all unqualified lookups. Make it allow unqualified lookups with a module selector.
@beccadax
Copy link
Contributor Author

@swift-ci please smoke test

@beccadax
[wip] Emit module selectors in swiftinterfaces
35f9aa7 
This support is currently opt-in and has several modes.
@beccadax
Copy link
Contributor Author

@swift-ci please build toolchain

@beccadax
Copy link
Contributor Author

@swift-ci build toolchain Windows platform

@beccadax
Copy link
Contributor Author

@swift-ci please test

@beccadax
Copy link
Contributor Author

@swift-ci build toolchain Windows platform

4 similar comments
@beccadax
Copy link
Contributor Author

@swift-ci build toolchain Windows platform

@beccadax
Copy link
Contributor Author

@swift-ci build toolchain Windows platform

@beccadax
Copy link
Contributor Author

@swift-ci build toolchain Windows platform

@beccadax
Copy link
Contributor Author

@swift-ci build toolchain Windows platform

@beccadax
Copy link
Contributor Author

@swift-ci build toolchain

1 similar comment
@beccadax
Copy link
Contributor Author

beccadax commented Sep 7, 2025

@swift-ci build toolchain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@ahoppen ahoppen Awaiting requested review from ahoppen

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@xymus xymus Awaiting requested review from xymus

@AnthonyLatsis AnthonyLatsis Awaiting requested review from AnthonyLatsis AnthonyLatsis is a code owner

@artemcm artemcm Awaiting requested review from artemcm artemcm will be requested when the pull request is marked ready for review artemcm is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli will be requested when the pull request is marked ready for review tshortli is a code owner

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver will be requested when the pull request is marked ready for review zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan will be requested when the pull request is marked ready for review egorzhdan is a code owner

@ian-twilightcoder ian-twilightcoder Awaiting requested review from ian-twilightcoder ian-twilightcoder will be requested when the pull request is marked ready for review ian-twilightcoder is a code owner

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun Xazax-hun will be requested when the pull request is marked ready for review Xazax-hun is a code owner

@j-hui j-hui Awaiting requested review from j-hui j-hui will be requested when the pull request is marked ready for review j-hui is a code owner

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar fahadnayyar will be requested when the pull request is marked ready for review fahadnayyar is a code owner

@susmonteiro susmonteiro Awaiting requested review from susmonteiro susmonteiro will be requested when the pull request is marked ready for review susmonteiro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beccadax @nkcsgexi